fix(builder): respect output.module with ESM output in the service-worker environment#8752
Open
BleedingDev wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for modernjs-byted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 5fb04b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 117 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b205e31264
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+89
to
+92
| chain.output.library({ | ||
| ...(chain.output.get('library') || {}), | ||
| type: 'module', | ||
| }); |
There was a problem hiding this comment.
When a service-worker build has output.module: true and an existing output.library.name from user/environment config, this spread preserves that name while changing the library type to module. Rspack requires module libraries to leave the library name unset, so this turns that previously valid commonjs2 worker configuration into a build-time validation error instead of producing ESM output. Strip or ignore name when selecting module output.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The service-worker environment always rewrites the bundler output library type to
commonjs2.When a user enables
output.module, the environment still ends up with a CJS library wrapper, so ESM worker output is not preserved.Fix
Detect service-worker bundler chains that already have module output enabled.
Use
type: 'module'for that case and keepcommonjs2for existing non-module service-worker output.Test
Added a builder unit test for the service-worker module-output branch.
Ran
PUPPETEER_SKIP_DOWNLOAD=1 pnpm install,pnpm --filter @modern-js/builder build, andpnpm --filter @modern-js/builder test.🤖 Generated with Claude Code